Move cache out of the worktree #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This action in action: https://github.com/tidyverse/blob/actions/runs/6445932389/job/17500507262#step:6:3405 . Any idea why sccache fails? |
|
Did you look at the test? Maybe you have to adapt he location at this line: https://github.com/hendrikmuhs/ccache-action/blob/main/.github/workflows/tests.yml#L59 |
|
Looks slightly better now, two tests are still failing. Do you agree that moving the cache out of tree is a good idea? |
yes, I think this is a good idea |
|
Let's see how far we get with the current implementation after #217. I still think the cache shouldn't live inside the worktree, let's discuss when this becomes an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #96.