Support for other types of ids #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @surfdude75 thanks for your contribution. I understand your concern. |
StarpTech
requested changes
Feb 21, 2018
store.js
Outdated
| @@ -88,17 +88,23 @@ class MongoStore extends Store { | |||
| * @memberOf MongoStore | |||
| */ | |||
| removeById(req) { | |||
| var id | |||
| try { | |||
| id = this.ObjectID(req.id) | |||
There was a problem hiding this comment.
This kind of check is really bad. We can't trust in that an exception is thrown. Please check the format via regex and swap it out in a separate function to avoid duplicate code.
There was a problem hiding this comment.
This is even better
var mongodb = require("mongodb"),
objectid = mongodb.BSONPure.ObjectID;
console.log(objectid.isValid('53fbf4615c3b9f41c381b6a3'));
|
Hi @StarpTech I hope it is as you requested. Let me know if it is necessary any other adjustment. Thanks. |
|
Hi @surfdude75 you cant use https://stackoverflow.com/a/25497438/1893773 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a legacy mongo database where not all ids are of type ObjectId.
It would be great if the plugin could try do not use ObjectId if the id is not compatible with the ObjectID.
Thanks and congrats for you great work.