-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add keychain provider for reading text/yaml/json secrets #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisimovdk
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
November 28, 2024 22:11
anisimovdk
force-pushed
the
add-keychain-provider
branch
3 times, most recently
from
November 28, 2024 22:22
a14be10
to
9f226ea
Compare
@anisimovdk please fix ci issues. thanks so much. |
anisimovdk
force-pushed
the
add-keychain-provider
branch
from
November 29, 2024 06:52
9f226ea
to
ce30aaf
Compare
aslafy-z
reviewed
Nov 29, 2024
Signed-off-by: Dmitry K. Anisimov <[email protected]>
anisimovdk
force-pushed
the
add-keychain-provider
branch
from
November 29, 2024 06:59
ce30aaf
to
e1afc0e
Compare
There is a problem with cross-platform build for lib github.com/keybase/go-keychain. |
Signed-off-by: Dmitry K. Anisimov <[email protected]>
anisimovdk
force-pushed
the
add-keychain-provider
branch
from
November 30, 2024 20:35
71f40a4
to
2d717de
Compare
yxxhero
reviewed
Dec 1, 2024
yxxhero
reviewed
Dec 1, 2024
Signed-off-by: Dmitry K. Anisimov <[email protected]>
aslafy-z
reviewed
Dec 2, 2024
Signed-off-by: Dmitry K. Anisimov <[email protected]>
yxxhero
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new provider for retrieving secrets from the macOS Keychain.