Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): first implementation of Doppler #175

Merged
merged 1 commit into from
Oct 8, 2023
Merged

feat(providers): first implementation of Doppler #175

merged 1 commit into from
Oct 8, 2023

Conversation

carnei-ro
Copy link
Contributor

Closes #173

@yxxhero
Copy link
Member

yxxhero commented Oct 7, 2023

@carnei-ro please fix conflicts.

@carnei-ro
Copy link
Contributor Author

@yxxhero PR rebased. Thanks for the heads-up.

@yxxhero
Copy link
Member

yxxhero commented Oct 7, 2023

@carnei-ro could you test it locally?

@carnei-ro
Copy link
Contributor Author

with doppler CLI:

$ DOPPLER_TOKEN=dp.st.production.Nu8.... doppler secrets
┌─────────────────────┬───────────────────────────────────────────────────────────────────────┬──────┐
│ NAME                │ VALUE                                                                 │ NOTE │
├─────────────────────┼───────────────────────────────────────────────────────────────────────┼──────┤
│ BAZ                 │ qux                                                                   │      │
│ DOPPLER_CONFIG      │ production                                                            │      │
│ DOPPLER_ENVIRONMENT │ production                                                            │      │
│ DOPPLER_PROJECT     │ delete-me                                                             │      │
│ FOO                 │ bar                                                                   │      │
│ MY_JSON_SECRET      │ {"some_string":"value", "some_number": 42,"some_list": ["apple","pine │      │
│                     │ apple"],"some_object":{"key_object_1":"val1","k2":"v2"},"some_bool":t │      │
│                     │ rue,"another_bool":false}                                             │      │
└─────────────────────┴───────────────────────────────────────────────────────────────────────┴──────┘

with vals:

doppler-test.yml:

all_secrets: ref+doppler:////
all_secrets_explicit_project_and_environment: ref+doppler://delete-me/production/
another_secret: ref+doppler://delete-me/production/BAZ
all_secrets_with_doppler_envs: ref+doppler://delete-me/production/?include_doppler_defaults=true
some_json_secret: ref+doppler://delete-me/production/MY_JSON_SECRET
some_secret: ref+doppler://delete-me/production/FOO
$ DOPPLER_TOKEN=dp.st.production.Nu8... bin/vals eval -f doppler-test.yml 

all_secrets: '{"BAZ":"qux","FOO":"bar","MY_JSON_SECRET":"{\"some_string\":\"value\", \"some_number\": 42,\"some_list\": [\"apple\",\"pineapple\"],\"some_object\":{\"key_object_1\":\"val1\",\"k2\":\"v2\"},\"some_bool\":true,\"another_bool\":false}"}'
all_secrets_explicit_project_and_environment: '{"BAZ":"qux","FOO":"bar","MY_JSON_SECRET":"{\"some_string\":\"value\", \"some_number\": 42,\"some_list\": [\"apple\",\"pineapple\"],\"some_object\":{\"key_object_1\":\"val1\",\"k2\":\"v2\"},\"some_bool\":true,\"another_bool\":false}"}'
all_secrets_with_doppler_envs: '{"BAZ":"qux","DOPPLER_CONFIG":"production","DOPPLER_ENVIRONMENT":"production","DOPPLER_PROJECT":"delete-me","FOO":"bar","MY_JSON_SECRET":"{\"some_string\":\"value\", \"some_number\": 42,\"some_list\": [\"apple\",\"pineapple\"],\"some_object\":{\"key_object_1\":\"val1\",\"k2\":\"v2\"},\"some_bool\":true,\"another_bool\":false}"}'
another_secret: qux
some_json_secret: '{"some_string":"value", "some_number": 42,"some_list": ["apple","pineapple"],"some_object":{"key_object_1":"val1","k2":"v2"},"some_bool":true,"another_bool":false}'
some_secret: bar

@yxxhero yxxhero merged commit 2594916 into helmfile:main Oct 8, 2023
@carnei-ro carnei-ro deleted the feat/doppler branch October 8, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: support Doppler
2 participants