Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for the OAS #466

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/ApiAppUpdate.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

$data = new Dropbox\Sign\Model\ApiAppUpdateRequest();
$data->setName("New Name")
->setCallbackUrl("http://example.com/dropboxsign")
->setCallbackUrl("https://example.com/dropboxsign")
->setWhiteLabelingOptions($whiteLabelingOptions)
->setCustomLogoFile($customLogoFile);

Expand Down
2 changes: 1 addition & 1 deletion examples/ApiAppUpdate.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

data = models.ApiAppUpdateRequest(
name="New Name",
callback_url="http://example.com/dropboxsign",
callback_url="https://example.com/dropboxsign",
white_labeling_options=white_labeling_options,
custom_logo_file=custom_logo_file,
)
Expand Down
2 changes: 1 addition & 1 deletion examples/ApiAppUpdate.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

data = Dropbox::Sign::ApiAppUpdateRequest.new
data.name = "New Name"
data.callback_url = "http://example.com/dropboxsign"
data.callback_url = "https://example.com/dropboxsign"
data.white_labeling_options = white_labeling_options
data.custom_logo_file = custom_logo_file

Expand Down
2 changes: 1 addition & 1 deletion examples/ApiAppUpdate.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
curl -X PUT 'https://api.hellosign.com/v3/api_app/{client_id}' \
-u 'YOUR_API_KEY:' \
-F 'name=New Name' \
-F 'callback_url=http://example.com/dropboxsign' \
-F 'callback_url=https://example.com/dropboxsign' \
-F 'white_labeling_options[primary_button_color]=#00b3e6' \
-F 'white_labeling_options[primary_button_text_color]=#ffffff'
2 changes: 1 addition & 1 deletion examples/ApiAppUpdate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const whiteLabelingOptions: DropboxSign.SubWhiteLabelingOptions = {

const data: DropboxSign.ApiAppUpdateRequest = {
name: "New Name",
callbackUrl: "http://example.com/dropboxsign",
callbackUrl: "https://example.com/dropboxsign",
customLogoFile: fs.createReadStream("CustomLogoFile.png"),
whiteLabelingOptions,
};
Expand Down
2 changes: 1 addition & 1 deletion examples/json/ApiAppCreateResponseExample.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"is_approved": false,
"name": "My Production App",
"oauth": {
"callback_url": "http://example.com/oauth",
"callback_url": "https://example.com/oauth",
"scopes": [
"basic_account_info",
"request_signature"
Expand Down
2 changes: 1 addition & 1 deletion examples/json/ApiAppGetResponseExample.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"is_approved": true,
"name": "My Production App",
"oauth": {
"callback_url": "http://example.com/oauth",
"callback_url": "https://example.com/oauth",
"scopes": [
"basic_account_info",
"request_signature"
Expand Down
2 changes: 1 addition & 1 deletion examples/json/ApiAppListResponseExample.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"is_approved": true,
"name": "My Production App",
"oauth": {
"callback_url": "http://example.com/oauth",
"callback_url": "https://example.com/oauth",
"scopes": [
"basic_account_info",
"request_signature"
Expand Down
2 changes: 1 addition & 1 deletion examples/json/ApiAppUpdateRequestDefaultExample.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "New Name",
"callback_url": "http://example.com/dropboxsign",
"callback_url": "https://example.com/dropboxsign",
"white_labeling_options": {
"primary_button_color": "#00b3e6",
"primary_button_text_color": "#ffffff"
Expand Down
4 changes: 2 additions & 2 deletions examples/json/ApiAppUpdateResponseExample.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"api_app": {
"callback_url": "http://example.com/dropboxsign",
"callback_url": "https://example.com/dropboxsign",
"client_id": "0dd3b823a682527788c4e40cb7b6f7e9",
"created_at": 1436232339,
"domains": ["example.com"],
"is_approved": false,
"name": "New Name",
"oauth": {
"callback_url": "http://example.com/oauth",
"callback_url": "https://example.com/oauth",
"scopes": [
"basic_account_info",
"request_signature"
Expand Down
2 changes: 1 addition & 1 deletion examples/json/FaxLineDeleteRequestExample.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"number": "[FAX_NUMBER]",
"number": "[FAX_NUMBER]"
}
4 changes: 2 additions & 2 deletions examples/json/FaxSendRequestExample.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"file_url": [
"file_urls": [
"https://api.hellosign.com/v3/fax/files/2b388914e3ae3b738bd4e2ee2850c677e6dc53d2"
],
"test_mode": "true",
Expand All @@ -9,4 +9,4 @@
"cover_page_message": "I'm sending you a fax!",
"cover_page_from": "Faxer Faxerson",
"title": "This is what the fax is about!"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,6 @@
"requirement": "require_0-1"
}
],
"type": "request_signature",
"test_mode": false
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,6 @@
]
}
],
"type": "request_signature",
"test_mode": false
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,6 @@
"page": 1
}
],
"type": "request_signature",
"test_mode": false
}
17 changes: 17 additions & 0 deletions openapi-raw.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1820,6 +1820,7 @@ paths:
- CA
- US
- UK
example: US
-
name: state
in: query
Expand Down Expand Up @@ -2101,6 +2102,7 @@ paths:
required: true
schema:
type: string
example: '[FAX_NUMBER]'
responses:
'200':
description: 'successful operation'
Expand Down Expand Up @@ -7765,6 +7767,11 @@ components:
- CA
- US
- UK
x-enum-varnames-override:
typescript-node:
- Ca
- Us
- Uk
city:
description: '_t__FaxLineCreate::CITY'
type: string
Expand Down Expand Up @@ -8612,6 +8619,16 @@ components:
enum:
- change-field-visibility
- change-group-visibility
x-enum-varnames-override:
csharp:
- FieldVisibility
- GroupVisibility
php:
- TYPE_FIELD_VISIBILITY
- TYPE_GROUP_VISIBILITY
typescript-node:
- FieldVisibility
- GroupVisibility
type: object
SubFormFieldRuleTrigger:
required:
Expand Down
17 changes: 17 additions & 0 deletions openapi-sdk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1826,6 +1826,7 @@ paths:
- CA
- US
- UK
example: US
-
name: state
in: query
Expand Down Expand Up @@ -2107,6 +2108,7 @@ paths:
required: true
schema:
type: string
example: '[FAX_NUMBER]'
responses:
'200':
description: 'successful operation'
Expand Down Expand Up @@ -7859,6 +7861,11 @@ components:
- CA
- US
- UK
x-enum-varnames-override:
typescript-node:
- Ca
- Us
- Uk
city:
description: City
type: string
Expand Down Expand Up @@ -8926,6 +8933,16 @@ components:
enum:
- change-field-visibility
- change-group-visibility
x-enum-varnames-override:
csharp:
- FieldVisibility
- GroupVisibility
php:
- TYPE_FIELD_VISIBILITY
- TYPE_GROUP_VISIBILITY
typescript-node:
- FieldVisibility
- GroupVisibility
type: object
SubFormFieldRuleTrigger:
required:
Expand Down
17 changes: 17 additions & 0 deletions openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1826,6 +1826,7 @@ paths:
- CA
- US
- UK
example: US
-
name: state
in: query
Expand Down Expand Up @@ -2107,6 +2108,7 @@ paths:
required: true
schema:
type: string
example: '[FAX_NUMBER]'
responses:
'200':
description: 'successful operation'
Expand Down Expand Up @@ -7859,6 +7861,11 @@ components:
- CA
- US
- UK
x-enum-varnames-override:
typescript-node:
- Ca
- Us
- Uk
city:
description: City
type: string
Expand Down Expand Up @@ -8904,6 +8911,16 @@ components:
enum:
- change-field-visibility
- change-group-visibility
x-enum-varnames-override:
csharp:
- FieldVisibility
- GroupVisibility
php:
- TYPE_FIELD_VISIBILITY
- TYPE_GROUP_VISIBILITY
typescript-node:
- FieldVisibility
- GroupVisibility
type: object
SubFormFieldRuleTrigger:
required:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Dropbox.Sign" Version="1.0.*" />
<PackageReference Include="Dropbox.Sign" Version="1.8.0-dev" />
</ItemGroup>
</Project>
Loading