Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add check for nats connection #107

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Conversation

hosseio
Copy link
Contributor

@hosseio hosseio commented Jun 27, 2023

Add new check for nats connection using official nats-io library.
For testing purpose the environment variable HEALTH_GO_NATS_DSN for the given docker-compose should be nats://127.0.0.1:4222

checks/nats/check.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lucasmdrs lucasmdrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint issue and add the required dependency to the docker-compose.yml

@hosseio
Copy link
Contributor Author

hosseio commented Jun 28, 2023

I was pretty sure I did 🤔
Good catch, thanks

Copy link
Contributor

@lucasmdrs lucasmdrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@lucasmdrs lucasmdrs merged commit c2891e9 into hellofresh:master Jun 28, 2023
6 checks passed
@hosseio
Copy link
Contributor Author

hosseio commented Jun 28, 2023

Thank you for the contribution!

Sure. I appreciate such a good work and I am using it. This is the less I can do :)

@hosseio hosseio deleted the check_nats branch June 29, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants