-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an optional parameter for render_table() #287
base: main
Are you sure you want to change the base?
Conversation
Add an optional parameter for render_table() to allow setting the location of the actions column. The two options are "front" (the 1st column of the table) and "end" (default value, the last column of the table).
Looks nice. @greyli how about |
Yes. that's also my first thought. I was struggling about that. But you are right, a bool will be better. And I found a more compact way to implement this function after I read Greyli's Flask book :). How can I recall this PR and edit it again? Thanks for the hlep. |
Use boolean type for the optional parameter (actions_first). Setting parameter for the repeating block in the template to make the codes more compact.
put your new edits in a new commit with a new commit message, then run change the first word before the commit message of the latest commit into save and exit that file, then remove the new commit messages and leave only the old commit message at the top of the next file. save and exit that and do |
Thanks for the instructions. But it seems quite complicated to me. I only use the github website operations. I suppose I have done the new commit. But I don't know how to move the PR from Draft back to acitve. Could you please help? Thanks! |
Just make another commmit and push that. @greyli can merge them later. |
I have moved the PR back to open status (2nd commit done). Thanks! |
Add an optional parameter for render_table() to allow setting the location of the actions column. The two options are "front" (the 1st column of the table) and "end" (default value, the last column of the table).