Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional parameter for render_table() #287

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

grant-sea
Copy link

Add an optional parameter for render_table() to allow setting the location of the actions column. The two options are "front" (the 1st column of the table) and "end" (default value, the last column of the table).

Add an optional parameter for render_table() to allow setting the location of the actions column. The two options are "front" (the 1st column of the table) and "end" (default value, the last column of the table).
@PanderMusubi
Copy link
Collaborator

Looks nice. @greyli how about actions_front=True using a bool instead of a string?

@grant-sea
Copy link
Author

Looks nice. @greyli how about actions_front=True using a bool instead of a string?

Yes. that's also my first thought. I was struggling about that. But you are right, a bool will be better. And I found a more compact way to implement this function after I read Greyli's Flask book :). How can I recall this PR and edit it again? Thanks for the hlep.

@grant-sea grant-sea marked this pull request as draft April 9, 2023 12:59
Use boolean type for the optional parameter (actions_first).  Setting parameter for the repeating block in the template to make the codes more compact.
@PanderMusubi
Copy link
Collaborator

put your new edits in a new commit with a new commit message, then run git rebase -i HEAD~2

change the first word before the commit message of the latest commit into squash

save and exit that file, then remove the new commit messages and leave only the old commit message at the top of the next file.

save and exit that and do git push -f which will push it here and override the old commit.

@grant-sea
Copy link
Author

put your new edits in a new commit with a new commit message, then run git rebase -i HEAD~2

change the first word before the commit message of the latest commit into squash

save and exit that file, then remove the new commit messages and leave only the old commit message at the top of the next file.

save and exit that and do git push -f which will push it here and override the old commit.

Thanks for the instructions. But it seems quite complicated to me. I only use the github website operations. I suppose I have done the new commit. But I don't know how to move the PR from Draft back to acitve. Could you please help? Thanks!

@PanderMusubi
Copy link
Collaborator

Just make another commmit and push that. @greyli can merge them later.

@grant-sea grant-sea marked this pull request as ready for review April 10, 2023 12:10
@grant-sea
Copy link
Author

Just make another commmit and push that. @greyli can merge them later.

I have moved the PR back to open status (2nd commit done). Thanks!

@PanderMusubi PanderMusubi requested a review from greyli June 11, 2023 15:00
@PanderMusubi PanderMusubi added the enhancement New feature or request label Oct 4, 2023
@greyli greyli removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request table
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants