feat: wrap selection in tag & wrap selection in function call #12254
+86
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new keys under "Add Surrounding". Now you can use:
msx
: Wrap selection with a tagmsf
: Wrap selection with a function callBoth of those commands bring up a prompt to allow you to input what you want.
In the examples below, the whole word is selected and we input
div
.Before
msx
-- Surround selection with tagmsf
-- Surround selection with function callIt implements some functionality from #12055 because implementing "delete surrounding tag", "change surrounding tag" is more complicated
I think that wrapping selection in a tag and a function is a pretty useful feature to have, this doesn't add to many lines of code so I think it's worth adding it here.
A different PR could implement "delete surrounding function" and "change surrounding function" if necessary.