Avoid allocating the --help message
#12243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integral-Tech
force-pushed
the
format-concat
branch
from
48eea74 to
ebd1c5d
Compare
Integral-Tech
changed the title
TornaxO7
reviewed
Dec 14, 2024
Integral-Tech
force-pushed
the
format-concat
branch
from
ebd1c5d to
8777d63
Compare
Integral-Tech
changed the title
|
@TornaxO7 I have just reverted the changes in |
|
Eh, I'm not a maintainer, so you needn't see my review as "mandatory". Those are just my two cents :> |
the-mikedavis
approved these changes
Dec 16, 2024
|
Yeah generally there's a tradeoff in refactoring for a performance gain. We typically try to avoid refactors unless they bring some concrete benefits. It'd be nice to not allocate this non-trivially-small string - previously we allocated it even when not printing the help message - and this block barely every changes so I'll merge this. |
the-mikedavis
changed the title
--help message
CedricMeu
pushed a commit
to CedricMeu/helix
that referenced
this pull request
Jan 2, 2025
GladkihEgor
pushed a commit
to GladkihEgor/helix
that referenced
this pull request
Jan 4, 2025
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format!macro is very powerful, it introduces overhead of memory allocation on the heap compared to&str. Therefore, whenformat!macro is unnecessary, we should avoid using it.