Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuing comment token for first line #12215

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

TornaxO7
Copy link
Contributor

@TornaxO7 TornaxO7 commented Dec 8, 2024

fixes #12165

@TornaxO7 TornaxO7 marked this pull request as draft December 8, 2024 10:02
@TornaxO7 TornaxO7 force-pushed the fix-comment-above branch 3 times, most recently from 03e923a to f8beb7a Compare December 8, 2024 10:15
@TornaxO7 TornaxO7 marked this pull request as ready for review December 8, 2024 10:15
@pascalkuthe
Copy link
Member

I wpuldnlike to see some integration tests for these cases

@pascalkuthe pascalkuthe added this to the next milestone Dec 8, 2024
@TornaxO7
Copy link
Contributor Author

TornaxO7 commented Dec 8, 2024

Aye Aye captain! Will do

@TornaxO7
Copy link
Contributor Author

TornaxO7 commented Dec 8, 2024

Alright, should be done!

peepoAwesome

pascalkuthe
pascalkuthe previously approved these changes Dec 8, 2024
@TornaxO7
Copy link
Contributor Author

Pulled from master.

@the-mikedavis the-mikedavis changed the title Fix continueing comment token for first line Fix continuing comment token for first line Dec 10, 2024
@the-mikedavis the-mikedavis merged commit 89a7cde into helix-editor:master Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behaviour for adding newline before a line with a comment on it
3 participants