feat: highlight directories with a different color in filename completion prompt #12205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaRevenco
changed the title
archseer
reviewed
Dec 7, 2024
|
@the-mikedavis what color key should be used for the directories? Should I add |
TornaxO7
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, directories and files both use the same color. This makes it hard to distinguish between them. This PR adds the ability to pass custom styles to prompt items.
Before
After
For now, I'm using
functionas the color key. I'm assuming there will need to be a new theme key added, for exampleui.text.directory? If so, would I need to add it to all the themes?