Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new statusline.merge-with-commandline option #12204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NikitaRevenco
Copy link
Contributor

@NikitaRevenco NikitaRevenco commented Dec 6, 2024

Having the command line and the statusline each take 2 rows may not be desirable to all.

Kakoune and Neovim both offer the option to merge these two lines into a single line.

The biggest problem is that since the status message is almost always empty, it takes up an entire line at the bottom of the screen which could be used by actual text instead.

I added a config option that merges the statusline and the command line into a single one. if there is an editor message, it replaces the bottom command line.


To enable it, run :toggle statusline.merge-with-commandline or add this into config.toml:

[editor.statusline]
merge-with-commandline: true
Before vs After

Before

image

After

image

Supersedes #12020
Closes #7934

@NikitaRevenco NikitaRevenco changed the title feat: option to Merge statusline and Command line into 1 line feat: new option statusline.merge-with-commandline to see 1 extra line of text in buffers Dec 6, 2024
@NikitaRevenco NikitaRevenco changed the title feat: new option statusline.merge-with-commandline to see 1 extra line of text in buffers feat: new option statusline.merge-with-commandline to see 1 extra line of text Dec 6, 2024
@NikitaRevenco NikitaRevenco changed the title feat: new option statusline.merge-with-commandline to see 1 extra line of text feat: new option statusline.merge-with-commandline Dec 6, 2024
@NikitaRevenco NikitaRevenco changed the title feat: new option statusline.merge-with-commandline feat: new statusline.merge-with-commandline option Dec 6, 2024
@rockboynton
Copy link

This made me think; what about swapping the command line and status line, and having the command line be "transparent" to the buffer/window by default? Then if you start typing a command, it pops up above the status line? Seems like the best of both worlds since you would still be able to see the status line when typing a command

@NikitaRevenco
Copy link
Contributor Author

NikitaRevenco commented Dec 12, 2024

This made me think; what about swapping the command line and status line, and having the command line be "transparent" to the buffer/window by default? Then if you start typing a command, it pops up above the status line? Seems like the best of both worlds since you would still be able to see the status line when typing a command

I think there's still value in having 1 line vs 2 lines at the bottom. I agree swapping them would be a better default (out of scope of this PR), but imo there should still be an option to merge them for those who want it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants