fix: allow to parse "-" as a key code #12191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Parsing |
sounds good, thanks! I made the change |
* We should keep the `tokens.last()` checking in the `match` branch: it ensures that we only take this branch if `s` ends with `--` or is `-`. Without it this branch would also apply to `S-` for example. * I've switched the string stuff to `trim_end_matches`. That should cover other odd cases like `S---`. * Instead of popping or clearing the `tokens` we can return early since there isn't any work to do parsing modifiers for `'-'`.
the-mikedavis
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12190