Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --default-config and --default-language-config command line arguments #12161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NikitaRevenco
Copy link
Contributor

@NikitaRevenco NikitaRevenco commented Nov 30, 2024

--default-config and -d will skip looking for a config file and instead use the default one

This is mainly useful for contributors who want to temporarily disable their config file without touch empty.toml && hx -c empty.toml

Closes #12157

@darshanCommits
Copy link
Contributor

Does it also take languages.toml into account?

@NikitaRevenco
Copy link
Contributor Author

NikitaRevenco commented Dec 1, 2024

Does it also take languages.toml into account?

It doesn't, which I think is the desired behavior?

@TornaxO7
Copy link
Contributor

TornaxO7 commented Dec 1, 2024

Hm... in my opinion, we shouldn't add this extra argument since, as you said, it's meant for contributors. I think I'd simply just create an alias like alias hxd="touch /tmp/helix_empty_config.toml && hx -c /tmp/helix_empty_config.toml".

@NikitaRevenco
Copy link
Contributor Author

NikitaRevenco commented Dec 1, 2024

Hm... in my opinion, we shouldn't add this extra argument since, as you said, it's meant for contributors. I think I'd simply just create an alias like alias hxd="touch /tmp/helix_empty_config.toml && hx -c /tmp/helix_empty_config.toml".

What if it's just a one off contribution and they don't want to make an alias? It'll be slightly easier for the contributor. I think making things easier for one-off contributors is a good idea

of course, this is just a point to consider

@darshanCommits
Copy link
Contributor

It doesn't, which I think is the desired behavior?

Would be nice if I could load the default languages.toml. I personally do have some use case.

The problem I see with it,
Should it be coupled with the config arg or a separate arg.

@NikitaRevenco
Copy link
Contributor Author

It doesn't, which I think is the desired behavior?

Would be nice if I could load the default languages.toml. I personally do have some use case.

The problem I see with it, Should it be coupled with the config arg or a separate arg.

I think it makes sense to have separate args, e.g. --default-language-config. Maybe shorthands are not necessary

@NikitaRevenco
Copy link
Contributor Author

--default-language-config and --default-config can both be used now, they don't have shorthands

@NikitaRevenco NikitaRevenco changed the title feat: add --default-config command line argument feat: add --default-config and --default-language-config command line arguments Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--default-config command line argument
3 participants