Skip to content

Commit

Permalink
Simplify change_current_directory and remove extra allocs
Browse files Browse the repository at this point in the history
  • Loading branch information
the-mikedavis committed Dec 5, 2024
1 parent 93deb1f commit 28953ef
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions helix-term/src/commands/typed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1090,18 +1090,14 @@ fn change_current_directory(
return Ok(());
}

let dir = match args.first() {
Some(Cow::Borrowed("-")) => cx
let dir = match args.first().map(AsRef::as_ref) {
Some("-") => cx
.editor
.last_cwd
.clone()
.ok_or(anyhow!("No previous working directory"))?,
Some(input_path) => {
helix_stdx::path::expand_tilde(Path::new(input_path.as_ref()).to_owned())
.deref()
.to_path_buf()
}
None => home_dir()?.as_path().to_owned(),
Some(input_path) => helix_stdx::path::expand_tilde(Path::new(input_path)).to_path_buf(),
None => home_dir()?,
};

cx.editor.last_cwd = helix_stdx::env::set_current_working_dir(dir)?;
Expand Down

0 comments on commit 28953ef

Please sign in to comment.