Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/675 on chain ouis devaddrs #431
base: master
Are you sure you want to change the base?
Feat/675 on chain ouis devaddrs #431
Changes from 36 commits
6060787
8cae4db
58cf64b
d2bf60c
b1734cc
c755093
bd87fdd
db7f998
2031f39
b2f4780
7a67eed
e827eeb
dc47049
040fc93
0e750c9
9ee2bb8
3b38d76
74c9d34
381423a
1e6ee06
3f245d4
3b7f815
1ea9ba3
02d5791
3abf8a9
e14d61a
174b779
3d10078
3b2249d
0a36e98
b5ababb
7d558b4
0623a99
c8a587f
d4ef2c9
ca0308c
c9431ea
e79b802
7557c35
9c907a8
4642b8f
8fde91e
fbdf4d3
25147f3
d46f7e9
2527773
0dd0e45
16239b5
fb7c2c4
4d8ea0f
a62acdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curiously, where is this function actuallly used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used in multiple places on this pr helium/helium-config-service-cli#67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right which really doesn't need to use instructions but can use the transaction form constructor functions, since they're all just passing in a single or fixed number of ixs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not following? Is it bad to just pass the instructions to
send_instructions
and have it do the transaction forming and sending? You're saying I should just callpack_instructions
in the config-service followed by a subsequent call of sending those transactions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is just called into_iter().try_collect()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting
unstable library feature 'iterator_try_collect'