4.x: Helidon Webclient (4.0.10) is not routing the requests through proxy configured using Proxy Builder. #9022 #9023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
jbescos
force-pushed
the
issue9022
branch
3 times, most recently
from
8345c2d to
af72d9e
Compare
…roxy configured using Proxy Builder. helidon-io#9022 Signed-off-by: Jorge Bescos Gascon <[email protected]>
klustria
previously approved these changes
Jul 24, 2024
There was a problem hiding this comment.
This LGTM already, so I'm approving. Also let's run this through @tomas-langer if he has any further comments
| @@ -587,6 +589,7 @@ public static class Builder implements io.helidon.common.Builder<Builder, Proxy> | |||
| private int port = 80; | |||
| private String username; | |||
| private char[] password; | |||
| private boolean httpConnect = true; | |||
There was a problem hiding this comment.
Maybe should default to false?
| response.close(); | ||
| throw new IllegalStateException("Proxy sent wrong HTTP response code: " + response.status()); | ||
| if (proxy.httpConnect) { | ||
| HttpClientRequest request = webClient.method(Method.CONNECT) |
There was a problem hiding this comment.
Is this block for http only? If not, do we also need to also check if the request is http?
tomas-langer
requested changes
Jul 24, 2024
webclient/api/src/main/java/io/helidon/webclient/api/Proxy.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
tomas-langer
requested changes
Jul 30, 2024
webclient/http1/src/main/java/io/helidon/webclient/http1/Http1ClientRequestImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jorge Bescos Gascon <[email protected]>
tomas-langer
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#9022
It will do HTTP CONNECT if any of these is true:
Documentation
None