Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include more unittests #14

Merged
merged 25 commits into from
May 24, 2024
Merged

Include more unittests #14

merged 25 commits into from
May 24, 2024

Commits on May 22, 2024

  1. Remove html file

    @bputzeys
    bputzeys committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e7efcf4 View commit details
    Browse the repository at this point in the history

  2. Add test to check if the input data is properly tokenized

    @bputzeys
    bputzeys committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e1af9b6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Adjust logger

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f512002 View commit details
    Browse the repository at this point in the history

  2. Remove unused variable token_gene_dict

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    45db64c View commit details
    Browse the repository at this point in the history

  3. Include geneformer unittests for tokenization

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f45c7c7 View commit details
    Browse the repository at this point in the history

  4. IDK why but this single test made an scggpt test 

    fail. No idea why as they are in different modules
and should not be related.
The failure is:
FAILED tests/test_scgpt/test_sampler.py::test_subsets_batch_sampler - assert [[0, 1, 2], [3, 4], [5, 6, 7], [8, 9]] != [[0, 1, 2], [3, 4], [5, 6, 7], [8, 9]]
    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6e63bd6 View commit details
    Browse the repository at this point in the history

  5. Add coverage report

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    fd5df13 View commit details
    Browse the repository at this point in the history

  6. Add coverage dependency

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    829bb6a View commit details
    Browse the repository at this point in the history

  7. Debug coverage report

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    63765f4 View commit details
    Browse the repository at this point in the history

  8. Include downloads otherwise does not work

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0ae1ae2 View commit details
    Browse the repository at this point in the history

  9. Try caching pip dependencies

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    53f9f52 View commit details
    Browse the repository at this point in the history

  10. Try with coverage report without comment from GithubAction

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    b4d0312 View commit details
    Browse the repository at this point in the history

  11. Debug coverage report

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    03fc91a View commit details
    Browse the repository at this point in the history

  12. Try caching downloads

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    7e7d307 View commit details
    Browse the repository at this point in the history

  13. Cache only UCE files, problem is that too much is tried to be cached

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    086d3f2 View commit details
    Browse the repository at this point in the history

  14. No space left on device error msg

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6b11bd8 View commit details
    Browse the repository at this point in the history

  15. Remove cache for UCE as there is no space 

    Include cache for pip
Try coverage report again
    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    dc4752a View commit details
    Browse the repository at this point in the history

  16. Add permission to comment on PR

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    68d0e71 View commit details
    Browse the repository at this point in the history

  17. Comment too long

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    119f0ce View commit details
    Browse the repository at this point in the history

  18. Adding comment does not work

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    297534e View commit details
    Browse the repository at this point in the history

  19. Add branch coverage

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    61b75d7 View commit details
    Browse the repository at this point in the history

  20. Include missing steps

    @bputzeys
    bputzeys committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5b3a0f0 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Upload coverage report as artifact

    @bputzeys
    bputzeys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    433393d View commit details
    Browse the repository at this point in the history

  2. Apparently pytest--cov needs an __init__ file

    @bputzeys
    bputzeys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    eb3ea35 View commit details
    Browse the repository at this point in the history

  3. Also include coverage report to terminal

    @bputzeys
    bputzeys committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d8cb522 View commit details
    Browse the repository at this point in the history