-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Incident Custom Fields and sanitize Orchestration PUT request #139
Add support for Incident Custom Fields and sanitize Orchestration PUT request #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this very needed fix @swbradshaw, however before moving on, there are a few comments which need to be addressed to continue with the merge. So, please if You find We need to discuss this further don't hesitate in reaching me out. ✌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏽
This reverts commit 2901b0d.
48f3aeb
to
737736f
Compare
This PR adds support for Incident Custom Fields on the Event Orchestration path. This feature will be released in January 2024. In addition it fixes the API call for updating the Event Orchestration.
Changes:
EventOrchestrationPathIncidentCustomFieldUpdate
struct which is an ID/Value pair of the custom fieldEventOrchestrationPathRuleActions
structpagerduty/event_orchestration_path_test.go
for new action typenull
values for arrays. This is not allowed by the API and results in an HTTP 400 Bad Request. I've added functionssanitizeOrchestrationPath
andsanitizeActions
to replace null values with empty arrays.The following is a test client I wrote to test this library. The code below simply gets the service orchestration and then updates it with the same object from the get request. Without the sanitize change, this library throws an error.