Add fine tuning experiment #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NivekT
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Looks good to me! Thank you for adding this. Just small comments:
- Might need to ask users to install
datasetsfrom HuggingFace up top - Is
file-nameon this lineopenai.FineTuningJob.create(training_file="file-name", model="gpt-3.5-turbo")correct? I guess that may be the default name? - How long does the fine-tuning job take? We can mention that as well so they know what to expect.
I think adding a SQL syntax validator (as an eval function) in the future can be cool.
Comment on lines
44
to
48
| dfs_to_concat = [df[columns_with_multiple_unique_values], df[unhashable_columns]] | ||
| if 'prompt' in df: | ||
| dfs_to_concat.append(df['prompt']) | ||
| if 'messages' in df: | ||
| dfs_to_concat.append(df['messages']) |
There was a problem hiding this comment.
Might need to check if it already exists in dfs_to_concat . Otherwise, you might get duplicate? Unless pd.concat handles duplication
There was a problem hiding this comment.
Good catch! I updated the logic to avoid duplicates
steventkrawczyk
force-pushed
the
ft-experiment
branch
from
b05d7a8
to
9497015
Compare
Totally agree that validating SQL is a good one, added an issue here: #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.