Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedded editor tests #4851

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add embedded editor tests #4851

wants to merge 1 commit into from

Conversation

TiBiBa
Copy link
Collaborator

@TiBiBa TiBiBa commented Dec 5, 2023

Start the name of the PR with one of the relevant prefixed in the title of the PR:

  • [LANGUAGE] -> changes related to grammars or the transpiler
  • [FIX] -> solving a bug
  • [CHORE] -> things unrelated to the code, such as mergify scripts
  • [REFACTORING] -> should not change anything, cleanup of code
  • [UI] -> improvements and changes of the Hedy user interface
  • [TESTING] -> changes made to the test suite
  • [BACKEND] -> changes to the internal logic of the Hedy website

Finish the name of the PR with a clear description of the changes and delete the lines above from the description.

Now fill out the remainder of this template by replacing all italic content

Description

Changes in detail. For example: "Adds translations of levels 1 to 12 to Polish" (note the use of present tense!)

Fixes issue or discussion number

Always link the number of the issue or of the discussion that your PR concerns.
Tip, if you use the word fixes before the issue number in this description, the related issue will automatically close then the PR is merged!

How to test

Checklist
Done? Check if you have it all in place using this list: (mark with x if done)

  • Contains one of the PR categories in the name
  • Describes changes in the format above
  • Links to an existing issue or discussion
  • Has a "How to test" section

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@ghost
Copy link

ghost commented Dec 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne
Copy link
Member

Hi @TiBiBa!

We are trying to clean up our PRs a bit, do you plan to move this forward? I see a lot of value for you in adding tests so that we don't break the LearnBeat integration, but we are not going to pick this up ourselves I think.

@jpelay jpelay self-requested a review July 31, 2024 00:15
@jpelay jpelay self-assigned this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants