Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make artifacts optional #24

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: make artifacts optional #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ jobs:
- name: Download Coverage
uses: actions/download-artifact@v4
with:
name: coverage.xml
path: .
pattern: coverage

- name: Check Coverage
id: coverage
run: test -e coverage/coverage.xml && echo "file=true" >> $GITHUB_OUTPUT || echo "file=false" >> $GITHUB_OUTPUT

- name: Select Project
env:
Expand All @@ -54,4 +59,4 @@ jobs:
args: >
-Dsonar.projectKey=${{ env.GITHUB_PROJECT }}
-Dsonar.organization=${{ github.repository_owner }}
-Dsonar.coverageReportPaths=coverage.xml
${{steps.coverage.outputs.file == 'true' && '-Dsonar.coverageReportPaths=coverage/coverage.xml' || ''}}
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ jobs:
- name: Download Build
uses: actions/download-artifact@v4
with:
name: build
path: dist
path: .
pattern: dist

- name: Setup Service
run: NODE_ENV=test npm run setup --if-present
Expand All @@ -101,5 +101,5 @@ jobs:
- name: Upload Coverage
uses: actions/upload-artifact@v4
with:
name: coverage.xml
name: coverage
path: coverage.xml
2 changes: 1 addition & 1 deletion .github/workflows/typescript.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ jobs:
- name: Upload Build
uses: actions/upload-artifact@v4
with:
name: build
name: dist
path: dist