Problem with proposed validation strategy proposed in #10 #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR implements the proposed validation strategy of issue #10. This would result in considerable simplification, including getting rid of the HedVersion class. Since the HEDTools cache the
HedSchema
objects for given schema versions, once one has been created, trying to create another withload_schema_version
just uses the cached version.The fundamental flaw with this approach is illustrated in lines 67 and 68 of
test_hed_tags
. The HedTags object must have a HED version when it is created, but it seems that adding columns to dynamic tables does not have the flexibility of passing additional parameters.Help would be appreciated.
@rly @oruebel