Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the validator script save schemas merged, not unmerged #996

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

IanCa
Copy link
Member

@IanCa IanCa commented Jul 26, 2024

to prevent an issue where it was saved with a with_standard schema that has since changed

…nt an issue where it was saved with a with_standard schema that has since changed
@IanCa IanCa closed this Jul 26, 2024
@IanCa IanCa reopened this Jul 26, 2024
@IanCa IanCa merged commit 5a1ff0e into hed-standard:develop Jul 26, 2024
14 of 15 checks passed
@VisLab
Copy link
Member

VisLab commented Jul 27, 2024

Since the validator already saves the .xml merged, I think this PR should be titled "save unmerged"?
I am not convinced that this should be done. Here is my reasoning:

A schema cannot be released if it is partnered with an unreleased schema. In general, except for testlib -- which we can change arbitrarily and is not guaranteed to be stable, prereleases of other library schemas should partner only with rereleased standard schema.

If a prerelease of a library schema needs to partner with an unreleased standard schema (which should happen rarely and only if there are some new anchor points that need to be added to the standard schema) then the administrators need to make sure that the library.xml is updated.

@IanCa please respond so we have a record of what is decided.

@IanCa
Copy link
Member Author

IanCa commented Jul 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants