Add hedId value checking to schema validation #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix version attribute for merged schemas Remove cache hit from scripts(I think it's not required, but we'll see...) rename tag_util -> util in the normal validator
|
spec tests fail because they're out of sync I believe, they run correctly locally for me with the newest json. |
|
I'm going to merge... BTW I think that any .json test file should have its error code listed in the hed_error_codes.json file. I see where these are more convenient, but they should probably be merged into one SCHEMA_ATTRIBUTE_INVALID. The name field somewhat takes care of it. @IanCa I assume that it doesn't change the tests? I'll leave it the way it is for now, but put it on the plan for merging those files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix version attribute for merged schemas
Remove cache hit from scripts(I think it's not required, but we'll see...)
rename tag_util -> util in the normal validator