Merge pull request #875 from IanCa/develop

Only flag spaces in units if they aren't deprecated
hed-standard · Feb 26, 2024 · dac5220 · dac5220
2 parents 59a0e9f + 9b4110a
commit dac5220
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/hed/schema/schema_compliance.py b/hed/schema/schema_compliance.py
@@ -126,10 +126,13 @@ def check_invalid_chars(self):
                 issues_list += validate_schema_description(tag_name, desc)
 
         if schema_version_greater_equal(self.hed_schema, "8.3.0"):
-            for unit in self.hed_schema.units:
-                for i, char in enumerate(unit):
+            for unit_name, unit in self.hed_schema.units.items():
+                # Don't check for spaces on deprecated units, to avoid degree Celsius issue
+                if unit.has_attribute(HedKey.DeprecatedFrom):
+                    continue
+                for i, char in enumerate(unit_name):
                     if char == " ":
                         issues_list += ErrorHandler.format_error(SchemaWarnings.SCHEMA_INVALID_CHARACTERS_IN_TAG,
-                                                                 unit, char_index=i, problem_char=char)
+                                                                 unit_name, char_index=i, problem_char=char)
 
         return issues_list