Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ruby 3.3 to CI #5668

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

berkos
Copy link
Contributor

@berkos berkos commented Jan 2, 2024

This PR adds Ruby 3.3 in the CI matrix.

It excludes rubies that are incompatible with Rails 7.2

Because every version of rails depends on Ruby >= 3.1.0
  and Gemfile-rails-main depends on rails >= 0,
  Ruby >= 3.1.0 is required.

@capripot
Copy link

capripot commented Apr 7, 2024

Yes please!

Copy link
Member

@carlosantoniodasilva carlosantoniodasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We can add the Ruby version to the build, but need to wait a bit until 7.2 is released to add a custom 7.1 gemfile to test against.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.1 is tested from our main Gemfile, we generally don't add a new / custom one until 7.2 is released. (that's when the Gemfile moves to test the current 7.2, and we add the previous as a custom Gemfile to continue testing it)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the review!
ah yes, I missed that main Gemfile is also in the matrix.
The updated commit should address it c80026d

- Exclude Rubies >=3.1 from latest main Gemfile as it runs on 7.2
@berkos berkos changed the title Update CI to run on Rails 7.1 and Ruby 3.3 Adds Ruby 3.3 to CI Apr 9, 2024
@carlosantoniodasilva carlosantoniodasilva merged commit 6ee12d1 into heartcombo:main Apr 9, 2024
21 checks passed
carlosantoniodasilva added a commit that referenced this pull request Apr 9, 2024
carlosantoniodasilva added a commit that referenced this pull request Apr 9, 2024
carlosantoniodasilva added a commit that referenced this pull request Apr 9, 2024
carlosantoniodasilva added a commit that referenced this pull request Apr 9, 2024
@berkos berkos deleted the update-ci branch May 24, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants