-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Ruby 3.3 to CI #5668
Adds Ruby 3.3 to CI #5668
Conversation
Yes please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. We can add the Ruby version to the build, but need to wait a bit until 7.2 is released to add a custom 7.1 gemfile to test against.
gemfiles/Gemfile-rails-7-1
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7.1 is tested from our main Gemfile, we generally don't add a new / custom one until 7.2 is released. (that's when the Gemfile moves to test the current 7.2, and we add the previous as a custom Gemfile to continue testing it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the review!
ah yes, I missed that main Gemfile is also in the matrix.
The updated commit should address it c80026d
- Exclude Rubies >=3.1 from latest main Gemfile as it runs on 7.2
Adds Ruby 3.3 to CI
Adds Ruby 3.3 to CI
This PR adds Ruby 3.3 in the CI matrix.
It excludes rubies that are incompatible with Rails 7.2