frontend: headlamp-plugin: Update react-markdown to 9.0.1 and remove github-markdown-css #2372
+1,589
−950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
illume
added
frontend
sniok
approved these changes
Oct 2, 2024
|
I'm pretty sure the github-markdown-css styles are not used anymore, it can be removed the styles were recently changed to better fit the rest of the app
I can open a separate request for that |
illume
force-pushed
the
github-markdown-css
branch
from
143c3b6
to
d67e218
Compare
illume
changed the title
…github-markdown-css Signed-off-by: René Dudfield <[email protected]>
illume
force-pushed
the
github-markdown-css
branch
from
d67e218
to
c1fa99f
Compare
|
Thanks @sniok Yeah, I tried it without the github-markdown-css import and it looked the same to me. So... I changed this PR to remove github-markdown-css now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-markdown to ^9.0.1
github-markdown-css is not used anymore
react-markdown release notes