Merge pull request #2315 from headlamp-k8s/namespace-create-button-label

frontend: Refactor labels for create namespace button
headlamp-k8s · Sep 25, 2024 · 03cd085 · 03cd085
2 parents 63f6229 + 8becdd6
commit 03cd085
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/frontend/src/components/namespace/CreateNamespaceButton.tsx b/frontend/src/components/namespace/CreateNamespaceButton.tsx
@@ -98,8 +98,9 @@ export default function CreateNamespaceButton() {
   return (
     <AuthVisible item={Namespace} authVerb="create">
       <ActionButton
+        data-testid="create-namespace-button"
         color="primary"
-        description={t('translation|Create')}
+        description={t('translation|Create Namespace')}
         icon={'mdi:plus-circle'}
         onClick={() => {
           setNamespaceDialogOpen(true);
@@ -143,15 +144,15 @@ export default function CreateNamespaceButton() {
         </DialogContent>
         <DialogActions>
           <Button
-            aria-label="Cancel"
+            data-testid="create-namespace-dialog-cancel-button"
             onClick={() => {
               setNamespaceDialogOpen(false);
             }}
           >
             {t('translation|Cancel')}
           </Button>
           <Button
-            aria-label="Create"
+            data-testid="create-namespace-dialog-create-button"
             disabled={!isValidNamespaceName}
             onClick={() => {
               createNewNamespace();

diff --git a/frontend/src/components/namespace/__snapshots__/NamespaceList.Regular.stories.storyshot b/frontend/src/components/namespace/__snapshots__/NamespaceList.Regular.stories.storyshot
@@ -21,7 +21,7 @@
               class="MuiBox-root css-ldp2l3"
             >
               <button
-                aria-label="Create"
+                aria-label="Create Namespace"
                 class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeMedium css-whz9ym-MuiButtonBase-root-MuiIconButton-root"
                 data-mui-internal-clone-element="true"
                 tabindex="0"