Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve html display for tables #998

Merged
merged 11 commits into from
Dec 1, 2023
Merged

improve html display for tables #998

merged 11 commits into from
Dec 1, 2023

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Nov 9, 2023

  • improve the title code
  • render tables correctly

I have not yet updated the tests

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

from pynwb.testing.mock.ecephys import mock_ElectricalSeries
from pynwb.testing.mock.ophys import mock_ImageSegmentation
ex1 = mock_ElectricalSeries()
ex2 = mock_ImageSegmentation()
image image

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

* improve the title code
* render tables correctly
@bendichter bendichter changed the title improve html display improve html display for tables Nov 9, 2023
src/hdmf/common/table.py Outdated Show resolved Hide resolved
@bendichter
Copy link
Contributor Author

@rly , @oruebel ok I did the restriction to the first 4 rows for each table.

image image

@rly
Copy link
Contributor

rly commented Nov 22, 2023

Looks good to me!

@oruebel
Copy link
Contributor

oruebel commented Nov 22, 2023

Looks good to me too.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (e517883) 88.65% compared to head (f008d3b) 88.57%.

Files Patch % Lines
src/hdmf/container.py 75.00% 6 Missing and 3 partials ⚠️
src/hdmf/common/table.py 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #998      +/-   ##
==========================================
- Coverage   88.65%   88.57%   -0.09%     
==========================================
  Files          45       45              
  Lines        9458     9487      +29     
  Branches     2691     2698       +7     
==========================================
+ Hits         8385     8403      +18     
- Misses        757      763       +6     
- Partials      316      321       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter marked this pull request as ready for review December 1, 2023 16:53
@bendichter bendichter requested review from rly and oruebel December 1, 2023 16:53
@rly
Copy link
Contributor

rly commented Dec 1, 2023

Looks good. There are some lines of code that we could cover with tests so we're not reducing our code coverage, but I think we can defer that to a separate PR so that this one can make it to users sooner.

@bendichter bendichter merged commit 434433e into dev Dec 1, 2023
28 checks passed
@bendichter bendichter deleted the improve_repr_html2 branch December 1, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants