-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use simpler tox.ini, add testing for Python 3.12, and other small updates #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #988 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 45 45
Lines 9451 9451
Branches 2688 2688
=======================================
Hits 8379 8379
Misses 757 757
Partials 315 315 ☔ View full report in Codecov by Sentry. |
rly
changed the title
[WIP] Test using a simpler more maintainable tox.ini
Test using a simpler tox.ini and add testing for Python 3.12
Oct 29, 2023
rly
changed the title
Test using a simpler tox.ini and add testing for Python 3.12
Use simpler tox.ini, add testing for Python 3.12, and other small updates
Oct 30, 2023
oruebel
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have to update
tox.ini
regularly when we want to test with new versions of python or make other changes to the testing infastructure. This PR simplifiestox.ini
and makes tox more efficient in some ways, though it makes it more complex in others. I think this will be easier to maintain, since the only changes we need to make when adding new versions of python are to the list of predefined environments (which technically do not need to be listed at all, but it is nice to).Add testing for Python 3.12. Fix [Feature]: Add tests for Python 3.12 #904.
Replace the
styfle/[email protected]
action with the github actionconcurrency
key that the workflow authors recommend.Change some links to absolute links in
README.rst
to work on the PyPI page.Update package versions in
environment-ros3.yml
Normally all warnings generated from
test_gallery.py
result in errors / test failures. I realize now that this is too strict forDeprecationWarning
s that come from updates to upstream packages. We should inspect those warnings when running local tests, but adding an exception for everyDeprecationWarning
from an upstream package that we have no control over is very tedious.How to test the behavior?