Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simpler tox.ini, add testing for Python 3.12, and other small updates #988

Merged
merged 19 commits into from
Oct 30, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 29, 2023

Motivation

  1. We have to update tox.ini regularly when we want to test with new versions of python or make other changes to the testing infastructure. This PR simplifies tox.ini and makes tox more efficient in some ways, though it makes it more complex in others. I think this will be easier to maintain, since the only changes we need to make when adding new versions of python are to the list of predefined environments (which technically do not need to be listed at all, but it is nice to).

  2. Add testing for Python 3.12. Fix [Feature]: Add tests for Python 3.12 #904.

  3. Replace the styfle/[email protected] action with the github action concurrency key that the workflow authors recommend.

  4. Change some links to absolute links in README.rst to work on the PyPI page.

  5. Update package versions in environment-ros3.yml

  6. Normally all warnings generated from test_gallery.py result in errors / test failures. I realize now that this is too strict for DeprecationWarnings that come from updates to upstream packages. We should inspect those warnings when running local tests, but adding an exception for every DeprecationWarning from an upstream package that we have no control over is very tedious.

How to test the behavior?

Run GitHub Actions workflows

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44d0d21) 88.65% compared to head (71704fc) 88.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #988   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          45       45           
  Lines        9451     9451           
  Branches     2688     2688           
=======================================
  Hits         8379     8379           
  Misses        757      757           
  Partials      315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly marked this pull request as ready for review October 29, 2023 00:35
@rly rly marked this pull request as draft October 29, 2023 00:35
@rly rly changed the title [WIP] Test using a simpler more maintainable tox.ini Test using a simpler tox.ini and add testing for Python 3.12 Oct 29, 2023
@rly rly marked this pull request as ready for review October 30, 2023 03:13
@rly rly changed the title Test using a simpler tox.ini and add testing for Python 3.12 Use simpler tox.ini, add testing for Python 3.12, and other small updates Oct 30, 2023
@rly rly requested a review from oruebel October 30, 2023 04:18
@rly rly merged commit 7687a3f into dev Oct 30, 2023
26 checks passed
@rly rly deleted the simplify_tox branch October 30, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add tests for Python 3.12
2 participants