-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TermSet minor test updates, _repr_html_, name field #967
Conversation
Fix #893 |
It's been a while since #893 but we don't have versions anymore, the prefixes can be called by "termset.sources", I added the name, I added repr_html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #967 +/- ##
==========================================
+ Coverage 88.59% 88.65% +0.06%
==========================================
Files 45 45
Lines 9424 9451 +27
Branches 2684 2688 +4
==========================================
+ Hits 8349 8379 +30
+ Misses 760 757 -3
Partials 315 315
☔ View full report in Codecov by Sentry. |
I did not move termset and herd to a folder as the issue ticket suggested. That would require a lot of import changes for something that doesn't provide much value to the user, nor me as the main person who works on this. |
The YAML schema in |
That makes sense to extract. |
@mavaylon1 thanks for the PR. I think printing "[item 1] [item 2] ... [item 3]" and "[item 1] [item 2] ... [item 3] [item 4]" when there are only 3 or 4 items in the list is misleading, so I changed the format a bit so that the ellipses only show up if there are more items present than are shown. Super minor, but I think it is better this way. Also, the panda that you added to your example is a genus, not a species, so I updated that accordingly. |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
How to test the behavior?
Run notebook for html representation and then the unit tests.
Checklist
ruff
from the source directory.