Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract _init_class_columns for use by DynamicTable subclasses #323

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Mar 25, 2020

This PR extracts code in DynamicTable.__init__ to DynamicTable._init_class_columns so that it can be called by subclasses of DynamicTable. This is necessary for the fix in NeurodataWithoutBorders/pynwb#1205

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #323 into dev will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #323      +/-   ##
==========================================
+ Coverage   72.73%   72.73%   +<.01%     
==========================================
  Files          33       33              
  Lines        6436     6438       +2     
  Branches     1411     1411              
==========================================
+ Hits         4681     4683       +2     
  Misses       1327     1327              
  Partials      428      428
Impacted Files Coverage Δ
src/hdmf/common/table.py 61.87% <66.66%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09e43e...a5acd41. Read the comment docs.

@rly rly merged commit 9828b91 into dev Mar 26, 2020
@rly rly deleted the enh/_init_class_columns branch March 26, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants