Temporarily revert breaking changes for bugfix release #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oruebel
approved these changes
Dec 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1224 +/- ##
==========================================
- Coverage 90.86% 89.00% -1.86%
==========================================
Files 42 45 +3
Lines 9520 9965 +445
Branches 2723 2831 +108
==========================================
+ Hits 8650 8869 +219
- Misses 576 774 +198
- Partials 294 322 +28 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had been preparing a major 4.0 release, but I think it could be a major burden on downstream tools to present breaking changes right before the winter holidays. However, there are some bug fixes that we would like to release in the meantime. I propose we revert the breaking changes (this PR), make a bugfix release, and add the breaking changes back in to dev. I can then make a pre-release and aim to do the major release on/around Jan 2.
The commit history will be a bit ugly, but I think that's OK. (We could adopt special release branches to make this situation easier in the future but that complicates the workflow and I think this situation is not that common.)