Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete src/hdmf/build/map.py #1221

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Delete src/hdmf/build/map.py #1221

merged 4 commits into from
Dec 20, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 19, 2024

Motivation

Removing this is part of the HDMF 4.0 deprecations.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (8194a8a) to head (fa084a5).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1221      +/-   ##
==========================================
+ Coverage   90.82%   90.86%   +0.03%     
==========================================
  Files          43       42       -1     
  Lines        9524     9520       -4     
  Branches     2723     2723              
==========================================
  Hits         8650     8650              
+ Misses        580      576       -4     
  Partials      294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly mentioned this pull request Dec 19, 2024
3 tasks
@rly rly marked this pull request as ready for review December 19, 2024 23:27
@rly rly enabled auto-merge (squash) December 19, 2024 23:46
@rly rly requested a review from oruebel December 19, 2024 23:46
@rly rly merged commit 6396a81 into dev Dec 20, 2024
27 checks passed
@rly rly deleted the rly-patch-2 branch December 20, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants