-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RegionBuilder and remaining references to region references #1212
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1212 +/- ##
=======================================
Coverage 90.94% 90.95%
=======================================
Files 43 43
Lines 9522 9506 -16
Branches 2722 2719 -3
=======================================
- Hits 8660 8646 -14
+ Misses 569 568 -1
+ Partials 293 292 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Let's wait for hdmf-dev/hdmf-zarr#236 and NeurodataWithoutBorders/pynwb#1991 to be merged into dev and the tests here re-run and passing before merging this PR. |
The HDMF-Zarr tests are failing because it pins to an older version of pynwb that has not accounted for the removal of |
I will review this tomorrow and we can merge. |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
How to test the behavior?
Checklist
CHANGELOG.md
with your changes?