Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RegionBuilder and remaining references to region references #1212

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 15, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.95%. Comparing base (a1af49d) to head (c951386).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1212   +/-   ##
=======================================
  Coverage   90.94%   90.95%           
=======================================
  Files          43       43           
  Lines        9522     9506   -16     
  Branches     2722     2719    -3     
=======================================
- Hits         8660     8646   -14     
+ Misses        569      568    -1     
+ Partials      293      292    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rly rly changed the title Remove RegionBuilder Remove RegionBuilder and remaining references to region references Nov 15, 2024
@rly
Copy link
Contributor Author

rly commented Nov 15, 2024

Let's wait for hdmf-dev/hdmf-zarr#236 and NeurodataWithoutBorders/pynwb#1991 to be merged into dev and the tests here re-run and passing before merging this PR.

@rly rly marked this pull request as ready for review November 18, 2024 23:53
@rly rly requested a review from mavaylon1 November 18, 2024 23:53
@rly
Copy link
Contributor Author

rly commented Nov 19, 2024

The HDMF-Zarr tests are failing because it pins to an older version of pynwb that has not accounted for the removal of RegionBuilder. The tests pass locally when using the dev version of pynwb. We should be releasing a bugfix version of pynwb this week, so these tests will pass. We can merge this PR now or wait.

@mavaylon1
Copy link
Contributor

The HDMF-Zarr tests are failing because it pins to an older version of pynwb that has not accounted for the removal of RegionBuilder. The tests pass locally when using the dev version of pynwb. We should be releasing a bugfix version of pynwb this week, so these tests will pass. We can merge this PR now or wait.

I will review this tomorrow and we can merge.

@mavaylon1 mavaylon1 enabled auto-merge (squash) November 21, 2024 19:30
@mavaylon1 mavaylon1 merged commit 4fb554a into dev Nov 21, 2024
29 checks passed
@mavaylon1 mavaylon1 deleted the rly-patch-2 branch November 21, 2024 19:35
@rly rly mentioned this pull request Dec 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants