-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write scalar datasets with compound data type #1176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephprince
changed the title
Write scalar compound datasets
Write scalar datasets with compound data type
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1176 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 45 45
Lines 9839 9844 +5
Branches 2797 2799 +2
=======================================
+ Hits 8746 8751 +5
Misses 776 776
Partials 317 317 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
rly
reviewed
Aug 21, 2024
rly
reviewed
Aug 21, 2024
Co-authored-by: Ryan Ly <[email protected]>
rly
approved these changes
Aug 22, 2024
Looks good to me! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This came up in NeurodataWithoutBorders/pynwb#1770, where
ElectrodeGroup.position
is a scalar dataset with a compound data type. There was an issue with write, so the written dataset was not scalar and/or values would be duplicated.Once this PR is incorporated, the related pynwb PR needs additional changes to the ElectrodeGroup position validation so that the position input is converted to a scalar with a compound data type. For example, something like:
How to test the behavior?
Checklist
CHANGELOG.md
with your changes?