Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy_release.yml #1030

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Update deploy_release.yml #1030

merged 1 commit into from
Jan 17, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Jan 17, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Update the the deploy workflow to use PyPi API tokens. This also is switching to the test pypi for continued testing on this issue.

What Changed?
The username secret was switched to __token__ and the password was switched to the API token (a unique token for test and actualy pypi). I believe this is the only change needed but I will test on test pypi

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (8892ba6) to head (4787dc8).
Report is 70 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1030   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files          45       45           
  Lines        9582     9582           
  Branches     2724     2724           
=======================================
  Hits         8481     8481           
  Misses        778      778           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review January 17, 2024 18:25
@mavaylon1 mavaylon1 self-assigned this Jan 17, 2024
@mavaylon1 mavaylon1 requested a review from rly January 17, 2024 18:25
@mavaylon1 mavaylon1 merged commit 9d1f378 into dev Jan 17, 2024
28 checks passed
@mavaylon1 mavaylon1 deleted the deploy branch January 17, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants