Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of datetime-formatted strings #1026

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 12, 2024

Motivation

Fix #1023

How to test the behavior?

pytest

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.46%. Comparing base (1a1d5ab) to head (821d982).
Report is 74 commits behind head on dev.

Files with missing lines Patch % Lines
src/hdmf/validate/validator.py 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1026      +/-   ##
==========================================
+ Coverage   88.38%   88.46%   +0.07%     
==========================================
  Files          45       45              
  Lines        9565     9579      +14     
  Branches     2720     2723       +3     
==========================================
+ Hits         8454     8474      +20     
+ Misses        784      781       -3     
+ Partials      327      324       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly requested a review from oruebel January 12, 2024 08:15
@rly rly enabled auto-merge (squash) January 12, 2024 20:55
@rly rly merged commit beb22b4 into dev Jan 12, 2024
28 checks passed
@rly rly deleted the fix_string_datetime_validator branch January 12, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Validator incorrectly reads datetime-formatted string as isodatetime when spec dtype is string
2 participants