Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken sphinx link in software_process.rst #1022

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix broken sphinx link in software_process.rst #1022

merged 1 commit into from
Jan 10, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 10, 2024

Motivation

Sphinx link-check cannot detect/resolve https://github.com/hdmf-dev/hdmf#readme . It seems like GitHub dynamically generates this anchor. This code https://github.com/sphinx-doc/sphinx/blob/master/sphinx/builders/linkcheck.py#L616 would normally detect it, but it looks like something changed with the GitHub layout a few days ago - there are now tabs on the main repo page for readme, code of conduct, and license.

This is minor enough not to need a changelog entry.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@rly rly requested a review from oruebel January 10, 2024 07:52
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a911d9c) 88.38% compared to head (4a05a13) 88.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1022   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files          45       45           
  Lines        9565     9565           
  Branches     2720     2720           
=======================================
  Hits         8454     8454           
  Misses        784      784           
  Partials      327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly merged commit b7cece2 into dev Jan 10, 2024
28 checks passed
@rly rly deleted the rly-patch-1 branch January 10, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants