Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_data_io to Data #1013

Merged
merged 17 commits into from
Dec 13, 2023
Merged

Add set_data_io to Data #1013

merged 17 commits into from
Dec 13, 2023

Conversation

CodyCBakerPhD
Copy link
Contributor

@CodyCBakerPhD CodyCBakerPhD commented Dec 10, 2023

fix #1012

Motivation

Outlined in issue

How to test the behavior?

  • add test
  • add deprecation warning

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@CodyCBakerPhD CodyCBakerPhD self-assigned this Dec 10, 2023
src/hdmf/container.py Outdated Show resolved Hide resolved
@bendichter
Copy link
Contributor

Thanks for working on this, @CodyCBakerPhD. I think this feature is really important. After this is integrated, I would like to also add a convenience method on DynamicTable. Something like DynamicTable.make_expandable, but let's save that for a separate PR after this one is merged.

# Conflicts:
#	src/hdmf/container.py
@bendichter
Copy link
Contributor

I'll take a stab and finishing this

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (cebb587) to head (eb59d65).
Report is 83 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1013   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files          45       45           
  Lines        9503     9509    +6     
  Branches     2703     2704    +1     
=======================================
+ Hits         8417     8423    +6     
  Misses        764      764           
  Partials      322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

add test for Data.set_data_io
@bendichter bendichter marked this pull request as ready for review December 12, 2023 16:37
@bendichter bendichter requested a review from rly December 12, 2023 16:56
src/hdmf/container.py Outdated Show resolved Hide resolved
src/hdmf/container.py Outdated Show resolved Hide resolved
rly
rly previously approved these changes Dec 12, 2023
@bendichter bendichter enabled auto-merge (squash) December 12, 2023 23:41
@bendichter bendichter disabled auto-merge December 12, 2023 23:42
@bendichter bendichter merged commit 41fabd4 into dev Dec 13, 2023
28 checks passed
@bendichter bendichter deleted the add_set_data_io_to_data branch December 13, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Deprecate Data.set_dataio and replace with Container.set_data_io logic
3 participants