Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with generating class with link and name #1006

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 6, 2023

Motivation

Fix #582 (the OP in #582 was resolved previously but this PR resolves the bug reported recently in the comments)

How to test the behavior?

pytest

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@rly rly requested a review from oruebel December 6, 2023 02:25
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (434433e) to head (e421d44).
Report is 90 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1006      +/-   ##
==========================================
- Coverage   88.57%   88.57%   -0.01%     
==========================================
  Files          45       45              
  Lines        9487     9484       -3     
  Branches     2698     2697       -1     
==========================================
- Hits         8403     8400       -3     
  Misses        763      763              
  Partials      321      321              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatched fixed name and included name causes errors on read/validate
2 participants