Merge branch 'wrapper' of https://github.com/hdmf-dev/hdmf into wrapper

hdmf-dev · Sep 28, 2023 · 91fef88 · 91fef88
2 parents 5d67899 + f1732ac
commit 91fef88
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,7 @@
 ## HDMF 3.9.1 (Upcoming)
 
 ### Enhancements
-- Updated `TermSet` to be used with `TermSetWrapper`, allowng for general use of validation for datasets and attributes. This also brings updates to `HERD` integration and updates on `write` to easily add references for wrapped datasets/attributes. @mavaylon1 [#950](https://github.com/hdmf-dev/hdmf/pull/950)
+- Updated `TermSet` to be used with `TermSetWrapper`, allowing for general use of validation for datasets and attributes. This also brings updates to `HERD` integration and updates on `write` to easily add references for wrapped datasets/attributes. @mavaylon1 [#950](https://github.com/hdmf-dev/hdmf/pull/950)
 
 ### Minor improvements
 - Removed warning when namespaces are loaded and the attribute marking where the specs are cached is missing. @bendichter [#926](https://github.com/hdmf-dev/hdmf/pull/926)

diff --git a/src/hdmf/backends/io.py b/src/hdmf/backends/io.py
@@ -84,11 +84,8 @@ def write(self, **kwargs):
 
         """Optional: Write HERD."""
         if self.herd_path is not None:
-            # If HERD is provided, extend it
-            if herd is not None:
-                pass
-            # If HERD is not provided, create a new one
-            else:
+            # If HERD is not provided, create a new one, else extend existing one
+            if herd is None:
                 from hdmf.common import HERD
                 herd = HERD(type_map=self.manager.type_map)