Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add support for SQLiteStore for ZarrIO #66

Closed
wants to merge 88 commits into from
Closed

[Feature] Add support for SQLiteStore for ZarrIO #66

wants to merge 88 commits into from

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 8, 2023

This is related to #62

This PR adds support for using the SQLiteStore zarr store with ZarrIO

oruebel and others added 27 commits January 5, 2023 00:22
@oruebel
Add support for using select user-defined zarr stores
9d26290
@oruebel
Update resolution of references to work also for file-based Zarr stores
0995543
@oruebel
Update test_io_zarr.py to allow file-based Zarr stores
1a94f17
@oruebel
Add SQLLite test draft
88d5dfb
@oruebel
Updated changelog
7076b82
@oruebel
Merge branch 'dev' into add/alternate_stores
2bb8d78
@oruebel
Merge branch 'dev' into add/alternate_stores
d9a3a75
@oruebel
Add ZarrIO.file property ease implementation of tests
1dca7df
@oruebel
Refactored ZarrIO tests for consistency and to run all backends via d…
022cf46 
…edicated test classes
@oruebel
Update NWBZarrIO to support the new path options from ZarrIO
0a59d9c
@oruebel
Minor changes to tests and comments
9b77f40
@oruebel
Update test_io_convert.py to test with all supported zarr.storage bac…
6a6b8f0 
…kends
@oruebel
Added docs on how to integrate new backends stores with ZarrIO
4c11f8c
@oruebel
Clarify the docs to integrate stores
9a28380
@oruebel
Update storage docs to add missing reserved links and groups
6fc99cb
@oruebel
Add DEFAULT_SPEC_LOC_DIR and SUPPORTED_ZARR_STORES module variable of…
c85052c 
… backend.py
@oruebel
Minor fixes to TempStore tests
a03bc32
@oruebel
Add Mixin and test cases to test convertion between Zarr and Zarr
e3e06a3
@oruebel
Update ZarrIO tutorial to describe using custom data stores
40c23ca
@oruebel
Update Changelog
03b16d4
@oruebel
Attempt to fix Windows tests
55daea8
@oruebel
Add note on why we set dir on TempStore
fd00185
@oruebel
Remove commented code
954cf4f
@oruebel
Fix bad test setup
18191d5
@oruebel
Set store paths in child classes
bc4386f
@oruebel
Added some more details to integrating_data_stores.rst
b18c41e
@oruebel
Added SQLiteStore support and tests (some link tests still failing)
731deeb
@oruebel oruebel added category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: storage issues related to storage schema and formats labels Jan 8, 2023
Base automatically changed from add/alternate_stores to dev January 18, 2023 08:01
@oruebel
Copy link
Contributor Author

oruebel commented Jan 18, 2023 •
edited
Loading

Windows errors are likely due to some SQLiteStore not being closed, preventing the file from being deleted. ad56654 and 595c9cb fixed most tests that failed with this sort of error, but at least one more failed test case on Windows still remains

@rly
Copy link
Contributor

rly commented Nov 7, 2024

Closing this due to lack of need.

@rly rly closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: storage issues related to storage schema and formats
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
3 participants
@oruebel @codecov-commenter @rly