Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove try/except around NWBZarrIO #242

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Remove try/except around NWBZarrIO #242

merged 5 commits into from
Nov 22, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 22, 2024

Motivation

Fix #241

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (8376fe4) to head (96e8cab).

Files with missing lines Patch % Lines
src/hdmf_zarr/nwb.py 72.22% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #242      +/-   ##
==========================================
+ Coverage   86.52%   86.65%   +0.12%     
==========================================
  Files           5        5              
  Lines        1210     1206       -4     
  Branches      304      304              
==========================================
- Hits         1047     1045       -2     
+ Misses        104      102       -2     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rly
Copy link
Contributor Author

rly commented Nov 22, 2024

The broken HDMF Dev Branch Compatibility workflow now correctly reports:

E   ImportError: cannot import name 'RegionBuilder' from 'hdmf.build' (/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/site-packages/hdmf/build/__init__.py)

with a useful stack trace instead of:

E   ImportError: cannot import name 'NWBZarrIO' from 'hdmf_zarr.nwb' (/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/site-packages/hdmf_zarr/nwb.py)

@rly rly requested a review from mavaylon1 November 22, 2024 06:08
@rly rly marked this pull request as ready for review November 22, 2024 06:08
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, we wanted to move NWBZarrIO to PyNWB at some point to make the import easier for users and more consistent with NWBHDF5IO

@rly rly merged commit 6fd9d53 into dev Nov 22, 2024
23 checks passed
@rly rly deleted the nwbzarrio branch November 22, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error handling in nwb.py masks true error
3 participants