Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Python 3.9 tests #231

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Fix broken Python 3.9 tests #231

merged 3 commits into from
Nov 19, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 9, 2024

Motivation

zarr 2.18.3 dropped support for Python 3.9 so our daily run all tests workflow is failing for Python 3.9 runs. I think a changelog entry is not needed for this change.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from mavaylon1 November 9, 2024 20:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (5a9055d) to head (513c11b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #231   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files           5        5           
  Lines        1188     1188           
  Branches      297      297           
=======================================
  Hits         1026     1026           
  Misses        103      103           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rly rly merged commit fedf38e into dev Nov 19, 2024
23 checks passed
@rly rly deleted the rly-patch-1 branch November 19, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants