Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .github/workflows/black.yml #227

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Delete .github/workflows/black.yml #227

merged 2 commits into from
Nov 8, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Nov 7, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Black is not integrated in our other repos and we have no plans to do so. We are removing it here.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1
Copy link
Contributor Author

Review Notes:
Did not update changelog because it is not a user facing change.

@mavaylon1 mavaylon1 requested a review from stephprince November 7, 2024 22:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (3a8e9c2) to head (083d335).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #227   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files           5        5           
  Lines        1185     1185           
  Branches      292      292           
=======================================
  Hits         1014     1014           
  Misses        115      115           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly enabled auto-merge (squash) November 8, 2024 19:52
@rly rly merged commit 797275a into dev Nov 8, 2024
22 checks passed
@rly rly deleted the black branch November 8, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants