Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 test #206

Merged
merged 5 commits into from
Jul 24, 2024
Merged

S3 test #206

merged 5 commits into from
Jul 24, 2024

Conversation

mavaylon1
Copy link
Contributor

Motivation

Fix #185
What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1 mavaylon1 marked this pull request as ready for review July 19, 2024 16:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@626341c). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #206   +/-   ##
======================================
  Coverage       ?   86.79%           
======================================
  Files          ?        5           
  Lines          ?     1159           
  Branches       ?      285           
======================================
  Hits           ?     1006           
  Misses         ?      101           
  Partials       ?       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 requested a review from stephprince July 19, 2024 16:59
@mavaylon1 mavaylon1 requested a review from stephprince July 24, 2024 02:50
@mavaylon1 mavaylon1 merged commit 2ba6bc5 into dev Jul 24, 2024
23 of 24 checks passed
@mavaylon1 mavaylon1 deleted the s3test branch July 24, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Remote read with/without consolidated metadata is not being tested
3 participants