Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default load_namespace #204

Merged
merged 4 commits into from
Jul 18, 2024
Merged

default load_namespace #204

merged 4 commits into from
Jul 18, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Jul 8, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Fix #198

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1
Copy link
Contributor Author

@rly Looking at the pynwb version of this (https://github.com/NeurodataWithoutBorders/pynwb/pull/1748/files#) I don't see any tests that tries to read a file with extensions. As a result, there isn't any tests I see that need to be updated. Maybe added, but I'm fine with that being a coverage PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.54%. Comparing base (a508d58) to head (b175dc9).

Files Patch % Lines
src/hdmf_zarr/nwb.py 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #204      +/-   ##
==========================================
+ Coverage   86.05%   86.54%   +0.48%     
==========================================
  Files           5        5              
  Lines        1162     1159       -3     
  Branches      287      285       -2     
==========================================
+ Hits         1000     1003       +3     
+ Misses        107      103       -4     
+ Partials       55       53       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

the ruff error is fixed in a different PR (the zarr append PR)

@mavaylon1 mavaylon1 marked this pull request as ready for review July 10, 2024 23:44
@mavaylon1 mavaylon1 requested a review from rly July 10, 2024 23:44
@rly
Copy link
Contributor

rly commented Jul 13, 2024

This looks good to me. Please add a changelog

@mavaylon1 mavaylon1 requested a review from stephprince July 18, 2024 16:57
@mavaylon1
Copy link
Contributor Author

@stephprince already approved by ryan. Just needed a changelog

@mavaylon1 mavaylon1 merged commit 626341c into dev Jul 18, 2024
23 of 24 checks passed
@mavaylon1 mavaylon1 deleted the loadns branch July 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: NWBZarrIO should have load_namespaces=True by default
4 participants