-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default load_namespace #204
Conversation
@rly Looking at the pynwb version of this (https://github.com/NeurodataWithoutBorders/pynwb/pull/1748/files#) I don't see any tests that tries to read a file with extensions. As a result, there isn't any tests I see that need to be updated. Maybe added, but I'm fine with that being a coverage PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #204 +/- ##
==========================================
+ Coverage 86.05% 86.54% +0.48%
==========================================
Files 5 5
Lines 1162 1159 -3
Branches 287 285 -2
==========================================
+ Hits 1000 1003 +3
+ Misses 107 103 -4
+ Partials 55 53 -2 ☔ View full report in Codecov by Sentry. |
the ruff error is fixed in a different PR (the zarr append PR) |
This looks good to me. Please add a changelog |
@stephprince already approved by ryan. Just needed a changelog |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
Fix #198
How to test the behavior?
Checklist
ruff
from the source directory.