Add sdupport for r- read mode to read without consolidated metadata #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For benchmarking and when consolidated metadata may be bad, it will be useful to force reading without consolidated metadata. This is needed for the nwb-benchmarks.
This PR:
r-
to force that a file is opened inr
mode without using consolidated metadata.ZarrIO.__open_file_consolidated
used properties ofZarrIO
instead of the provided input parameters. This did not cause any errors so far, since the values matched but is still something that could have caused issues later on.-r
read modeZarrStoreTestCase
which assumed in thetearDown
that the output file was always being created, so clean-up would fail if a test-case did not create a file.Checklist
ruff
from the source directory.